Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coqPackages.dpdgraph: fix build with OCaml ≥ 4.08 #84459

Merged
merged 1 commit into from Apr 13, 2020
Merged

coqPackages.dpdgraph: fix build with OCaml ≥ 4.08 #84459

merged 1 commit into from Apr 13, 2020

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 6, 2020

Motivation for this change

dpdgraph currently does not build for Coq ≥ 8.10

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 6, 2020

@GrahamcOfBorg build coqPackages.dpdgraph coqPackages_8_10.dpdgraph

@vbgl vbgl merged commit f2eeeb8 into NixOS:master Apr 13, 2020
@vbgl vbgl deleted the coq-dpdgraph-warnerr branch April 13, 2020 09:04
@vbgl
Copy link
Contributor Author

vbgl commented Apr 13, 2020

Backported as 1610b4a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: coq 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@vbgl