Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nomad: 0.10.2 -> 0.10.5 #84400

Merged
merged 1 commit into from Apr 8, 2020
Merged

nomad: 0.10.2 -> 0.10.5 #84400

merged 1 commit into from Apr 8, 2020

Conversation

numkem
Copy link
Contributor

@numkem numkem commented Apr 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from rushmorem and endocrimes April 5, 2020 22:02
endocrimes
endocrimes reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nlewo
Copy link
Member

nlewo commented Apr 8, 2020

@endocrimes Thanks for your review. If you approve the PR with GitHub UI, a label approved is added and visible from the PR list. This makes the review process easier ;)

@nlewo nlewo merged commit bb3e588 into NixOS:master Apr 8, 2020
@numkem numkem deleted the nomad_0.10.5 branch April 27, 2020 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@endocrimes endocrimes endocrimes left review comments

@rushmorem rushmorem Awaiting requested review from rushmorem

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@numkem @nlewo @endocrimes