Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clj-kondo: 2020.03.20 -> 2020.04.05 #84354

Merged
merged 1 commit into from Apr 21, 2020
Merged

clj-kondo: 2020.03.20 -> 2020.04.05 #84354

merged 1 commit into from Apr 21, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace @AndersonTorres

@ofborg ofborg bot requested a review from jlesquembre April 5, 2020 13:26
@FRidh
Copy link
Member

FRidh commented Apr 5, 2020

@GrahamcOfBorg build clj-kondo

@jlesquembre
Copy link
Member

It looks good to me. Unfortunately, graalvm8 is broken on master:
https://hydra.nixos.org/job/nixpkgs/trunk/graalvm8.x86_64-linux
I was able to build it with graalvm11-ee, I think it should work with graalvm8 once it is fixed.

@bennyandresen bennyandresen mentioned this pull request Apr 7, 2020
Merged
10 tasks
@bennyandresen
Copy link
Contributor Author

graalvm8 builds for me, but it consumes 24GB and takes 70 Minutes on my 8-thread Intel. Maybe that's a bit outside the hydra normality.

@bennyandresen bennyandresen mentioned this pull request Apr 7, 2020
Closed
@bennyandresen
Copy link
Contributor Author

bennyandresen commented Apr 8, 2020 •
edited

for the next reviewer:

according to @hlolli in #83080 the package can't be built because it gets OOM-killed in grahamofborg's build.
I measured the peak memory resource consumption at 25GB when I built it myself.

It builds fine on my system and could be included, as the situation is the same for 2020.03.20

@FRidh FRidh merged commit e759331 into NixOS:master Apr 21, 2020
@bennyandresen bennyandresen deleted the clj-kondo_2020.03.20->2020.04.05 branch May 20, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre jlesquembre approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bennyandresen @FRidh @jlesquembre