k3s: init at 1.17.3+k3s1 #84325
Merged
k3s: init at 1.17.3+k3s1 #84325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This packages k3s as a single self-contained binary (as upstream k3s does), but without having to download any impure already-built binaries. The upstream packaging scripts are used. Due to k3s's rather complicated packaging arrangement, this ends up being a rather long derivation.
cleverca22
reviewed
Apr 5, 2020
| @@ -0,0 +1,233 @@ | |||
| with import <nixpkgs> {}; | |||
There was a problem hiding this comment.
this line fails to build on hydra: https://hydra.nixos.org/build/116132269
There was a problem hiding this comment.
I wonder how this wasn't caught on ofborg. cc @grahamc
flokli
reviewed
Apr 5, 2020
|
|
||
| patches = [ ./patches/00-k3s.patch ]; | ||
|
|
||
| nativeBuildInputs = [ pkgconfig autoPatchelfHook breakpointHook ]; |
There was a problem hiding this comment.
please also remove breakpointHook - that's for interactive development, not for nixpkgs.
There was a problem hiding this comment.
in fact, the aarch64 build failed, and was stuck in a breakpointHook :-/
There was a problem hiding this comment.
Yeah, sorry about that! I was debugging an issue locally and forgot to delete it. I'll make a followup PR with some improvements, and I'll get the aarch64 build either working or properly skipped there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This packages k3s as a single self-contained binary (as upstream k3s
does), but without having to download any impure already-built binaries.
The upstream packaging scripts are used. Due to k3s's rather complicated
packaging arrangement, this ends up being a rather long derivation.
Motivation for this change
k3s is handy to have on nix and nixos. This gets the binary built, and I intend to add a nixos service as a followup to this.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)