Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminance-hdr: use Qt5's mkDerivation #84361

Merged
merged 1 commit into from Apr 14, 2020
Merged

luminance-hdr: use Qt5's mkDerivation #84361

merged 1 commit into from Apr 14, 2020

Conversation

dominikh
Copy link
Contributor

@dominikh dominikh commented Apr 5, 2020

Motivation for this change

Fix luminance-hdr as per #65399

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from hrdinka April 5, 2020 15:32
mmilata
mmilata approved these changes Apr 7, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With these changes the program no longer crashes on startup.

Cosmetic: maybe put the mkDerivation at the beginning of the argument list?

@dominikh dominikh force-pushed the luminanceHDR-wrapQtAppsHook branch from 321fdad to b233a19 Compare April 7, 2020 23:39
@dominikh
Copy link
Contributor Author

dominikh commented Apr 7, 2020

Cosmetic: maybe put the mkDerivation at the beginning of the argument list?

Done.

@worldofpeace worldofpeace merged commit a6e85bd into NixOS:master Apr 14, 2020
@worldofpeace
Copy link
Contributor

backported to:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

@hrdinka hrdinka Awaiting requested review from hrdinka

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dominikh @worldofpeace @mmilata