Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ly: 0.2.1 -> 0.5.0 #84408

Closed
wants to merge 1 commit into from
Closed

ly: 0.2.1 -> 0.5.0 #84408

wants to merge 1 commit into from

Conversation

michalrus
Copy link
Member

@michalrus michalrus commented Apr 5, 2020 •
edited

Motivation for this change

Version bump.

It’s been stale for a long of time, because upstream decided to break their .gitmodules… I fixed that by modifying nix-prefetch-git just for this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from spacekookie April 5, 2020 22:57
puzzlewolf
puzzlewolf suggested changes May 20, 2020
View reviewed changes
Copy link
Contributor

@puzzlewolf puzzlewolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and the binary starts 👍. Can't speak to your changes, sry :)

Please add quotation marks for the url in meta.homepage (RFC 45), while you're at it. And maybe also add meta.platform, otherwise I think the package will not be built by Hydra (see manual ch. 7.1).

@stale
Copy link

stale bot commented Nov 21, 2020

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 21, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@SuperSandro2000
Copy link
Member

@michalrus please resolve the merge conflict.

@tomberek
Copy link
Contributor

Rebased onto master, but still had git errors:

Switched to a new branch 'fetchgit'
Submodule 'sub/argoat' (https://github.com/cylgom/argoat.git) registered for path 'sub/argoat'
Submodule 'sub/configator' (https://github.com/cylgom/configator.git) registered for path 'sub/configator'
Submodule 'sub/ctypes' (https://github.com/cylgom/ctypes.git) registered for path 'sub/ctypes'
Submodule 'sub/dragonfail' (https://github.com/cylgom/dragonfail.git) registered for path 'sub/dragonfail'
Submodule 'sub/termbox_next' (https://github.com/cylgom/termbox_next.git) registered for path 'sub/termbox_next'
Initialized empty Git repository in /nix/store/ax1snc4wgqv5f8s7yyswyxpgy8jiww7f-ly/sub/argoat/.git/
remote: Enumerating objects: 30, done.
remote: Counting objects: 100% (30/30), done.
remote: Compressing objects: 100% (28/28), done.
remote: Total 110 (delta 1), reused 30 (delta 1), pack-reused 80
Receiving objects: 100% (110/110), 58.52 KiB | 1.95 MiB/s, done.
Resolving deltas: 100% (39/39), done.
From https://github.com/cylgom/argoat
 * [new branch]      master     -> origin/master
 * [new tag]         v0.1.0     -> v0.1.0
fatal: git cat-file: could not get object info
Unrecognized git object type:
Unable to checkout 36c41f09ecc2a10c9acf35e4194e08b6fa10cf45 from https://github.com/cylgom/argoat.git.

@stale
Copy link

stale bot commented Aug 24, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 24, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puzzlewolf puzzlewolf puzzlewolf requested changes

@spacekookie spacekookie Awaiting requested review from spacekookie

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michalrus @SuperSandro2000 @tomberek @puzzlewolf