-
-
Notifications
You must be signed in to change notification settings - Fork 968
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTTD 1.10 breaks compatibility of Admin port #8060
Comments
I agree, the best choice is to move the new enum value to the end. And I think @duckfullstop may have some inputs too. |
Possible fix in #8061. My comment from above about sending both ACTION_LEAVE and ACTION_KICKED is void. That change only affects the regular client-server API (which is version specific anyway), it does not affect the admin network api. |
This one has affected us at Reddit OpenTTD: I’ve patched our ancient version of libottdadmin2 to shift everything to the right places, but I’m not sure changing protocol again in the next version is a sane choice: that is unless it’s a hotfix that can be deployed quickly. That being said, moving things back means that everyone’s libraries don’t have to be updated. Yin/yang, I guess. |
Commit 5880f14 breaks compatibility of the Admin Port API by inserting an item in the middle of an enum.
Since this breaks all external libraries which connect to OpenTTD, I suggest to break the API again in 1.10.1 and to revert to the old enum values (by moving the new enum value to the end).
Reasoning:
I am not sure what API client @bjarnithor99 used when testing. Maybe you have some input as well.
The text was updated successfully, but these errors were encountered: