Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

itstool: fix double-shebang backport #84334

Merged
merged 2 commits into from
Apr 6, 2020
Merged

itstool: fix double-shebang backport #84334

merged 2 commits into from
Apr 6, 2020
+8 −2

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 5, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

burke and others added 2 commits April 5, 2020 12:23
@burke @LnL7
itstool: fix double-shebang issue on macOS

Partially verified

This commit is signed with the committer’s verified signature. The key has expired.
LnL7’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
6e14cf0 
(cherry picked from commit 9761d5a)
@Mic92 @LnL7
itstool: use wrapPython to fix double shebang on macOS

Verified

This commit was signed with the committer’s verified signature. The key has expired.
LnL7 Daiderd Jordan
GPG key ID: D02435D05B810C96
Expired
Verified
Learn about vigilant mode
7601af2 
(cherry picked from commit 02a5f3e)
@LnL7 LnL7 requested review from FRidh and worldofpeace April 5, 2020 10:28
@worldofpeace worldofpeace added this to the 20.03 milestone Apr 6, 2020
@worldofpeace worldofpeace added the 1.severity: blocker This is preventing another PR or issue from being completed label Apr 6, 2020
@LnL7 LnL7 merged commit 10f8099 into NixOS:staging-20.03 Apr 6, 2020
@LnL7 LnL7 deleted the darwin-itstool branch April 6, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace

@FRidh FRidh

Assignees
No one assigned
Labels
1.severity: blocker This is preventing another PR or issue from being completed 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LnL7 @worldofpeace @burke @Mic92