Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

darwin 20.03 backports #84332

Merged
merged 7 commits into from Apr 6, 2020
Merged

darwin 20.03 backports #84332

merged 7 commits into from Apr 6, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 5, 2020

Motivation for this change

Various darwin backports for 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

sikmir and others added 7 commits April 4, 2020 20:34
@sikmir @LnL7
osm2pgsql: enable on darwin
ee4164e 
(cherry picked from commit d6f5459)
@sikmir @LnL7
goldendict: enable on darwin
3c39e18 
(cherry picked from commit 217b221)
@mmahut @LnL7
cloudflare-wrangler: adding dependencies for darwin
b460ece 
(cherry picked from commit 6274ce1)
@marsam @LnL7
lepton: enable on darwin
06fe4b2 
(cherry picked from commit 310b108)
@veprbl @LnL7
mame: add darwin support
8876e5e 
(cherry picked from commit 39921bd)
@veprbl @LnL7
higan: fix darwin build
feacec6 
(cherry picked from commit 4c931a8)
@cgevans @LnL7
libunique: add darwin
5de67df 
libunique builds, and dependencies appear to build and run correctly,
in OS X.

(cherry picked from commit 45c9ad3)
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Apr 5, 2020
ghost
ghost reviewed Apr 5, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Mac to review

@veprbl
Copy link
Member

veprbl commented Apr 5, 2020

Could pick up cacbbe9 as well

@LnL7
Copy link
Member Author

LnL7 commented Apr 5, 2020

@veprbl That one doesn't apply cleanly anymore so it was skipped.

@LnL7 LnL7 merged commit ef0537b into NixOS:release-20.03 Apr 6, 2020
@LnL7 LnL7 deleted the darwin-backports branch April 6, 2020 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir approved these changes

@gebner gebner Awaiting requested review from gebner

@astsmtl astsmtl Awaiting requested review from astsmtl

@jglukasik jglukasik Awaiting requested review from jglukasik

@AndersonTorres AndersonTorres Awaiting requested review from AndersonTorres

@artemist artemist Awaiting requested review from artemist

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@LnL7 @veprbl @sikmir @mmahut @marsam @cgevans