Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ardour: clean up the expression #84470

Merged
merged 4 commits into from Apr 13, 2020
Merged

ardour: clean up the expression #84470

merged 4 commits into from Apr 13, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Apr 6, 2020 •
edited

Motivation for this change

Wanted to clean up gnome2 packages for #39976 but it got out of hand.

cc @cillianderoiste @fps

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from cillianderoiste April 6, 2020 13:49
@jtojnar jtojnar added this to To do in Picking up garbage via automation Apr 7, 2020
@jtojnar jtojnar moved this from To do to In progress in Picking up garbage Apr 7, 2020
@jtojnar
ardour: format with nixpkgs-fmt
eac0ee6
@jtojnar
kissft: init at 131
602bf81
@jtojnar
qm-dsp: init at 1.7.1
1ff54d0
@jtojnar
ardour: clean up the expression
3f7515c 
* Remove unneeded dependencies
* Stop vendoring other dependencies (fluidsynth, hidapi, libltc, qm-dsp)
* Fix using incorrect libusb version (libusb package is just a legacy compat layer)
* Move build-time dependencies to nativeBuildInputs
* Install freedesktop files & man page
* Drop libintl replacement that no longer applies
@jtojnar jtojnar merged commit cc57640 into NixOS:master Apr 13, 2020
Picking up garbage automation moved this from In progress to Done Apr 13, 2020
@jtojnar jtojnar deleted the ardour-cleanup branch April 13, 2020 18:10
@OPNA2608 OPNA2608 mentioned this pull request Apr 13, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
Picking up garbage
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@jtojnar