Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging next #84442

Merged
merged 52 commits into from Apr 18, 2020
Merged

Staging next #84442

merged 52 commits into from Apr 18, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Apr 6, 2020

Motivation for this change

https://hydra.nixos.org/jobset/nixpkgs/staging-next

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

roastiek and others added 30 commits March 29, 2020 20:34
Since we select everything as a module, snd_hda_codec_ca0132 is built as
well. DSP loading is not enabled by default, but without it the
soundcard produces timeouts within ALSA and does not emit sound.
Explicitly enable the firmware loading to ensure Soundblaster
Z/Zx/ZxR/Recon devices can be used with NixOS.
The patch to enable this by default in the kernel is staged for 5.8.
tree-wide: Switch from gnome3.maintainers to lib.teams.gnome
fetchpatch can't be used here and fetchurl from GitHub
like in PR #82928 has the risk of breaking the hash later;
fortunately the patches aren't too large.

(cherry picked from commit 2071e3b)
pyca/pyopenssl#899 (comment)
The tests in python3.pkgs.pyopenssl succeed!
Fixing this problem we experienced is listed as the only major change:
https://www.openssl.org/news/openssl-1.1.1-notes.html
This contains at least golang/go#37807, which
currently causes some of our go binaries to just fail when booted with
older kernels.

See golang/go#37436 for context.
linux config: enable Creative Soundblaster DSP loading
Adding phases to preInstallPhases is not possible in preBuild since by that time, phases is already populated.
@jonringer
Copy link
Contributor

#84660 should probably be included in this.

Fixes build regression (after alsa update, I assume).
Despite the version number change, the diff is trivial:
https://git.alsa-project.org/?p=alsa-tools.git;a=log;h=refs/tags/v1.2.2
@vcunat
Copy link
Member

vcunat commented Apr 17, 2020

There are apparently some python regressions that break e.g. nixops. One way might be to migrate anything important away from python2 anyway, but pyopenssl might be too important...

@FRidh
Copy link
Member Author

FRidh commented Apr 17, 2020

Probably best to drop nixops in Nixpkgs since it's changed quite a bit upstream cc @adisbladis @grahamc

... most notably fix pyopenssl.  I can't say I really understand this,
but the commit seems safe enough.
Hydra nixpkgs: ?compare=1582510
@vcunat
Copy link
Member

vcunat commented Apr 18, 2020

I fixed it somehow in 312e903; feel free to improve.

@primeos primeos mentioned this pull request Apr 18, 2020
10 tasks
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Hydra it looks good. About a third of darwin packages still hasn't been finished, but that risk seems acceptable – on the other hand we have security fixes inside.

@vcunat vcunat merged commit e233a9d into master Apr 18, 2020
@adisbladis
Copy link
Member

@FRidh A new release of NixOps is still pretty far away, in the mean time we need the current release.

If you'd like I can try to repackage the current release using Poetry/poetry2nix so NixOps won't be blocking any progression in pythonPackages?

@vcunat
Copy link
Member

vcunat commented Apr 20, 2020

I fixed the build of pyopenssl which was blocking it, so nixops builds now and I don't expect you need to hurry with anything.

@ghost
Copy link

ghost commented Apr 21, 2020

I could need some help with #85668. Both parent commits of this merge commit work fine, but waybar built from the merge commit does not (starts up fine but doesn't show the bar). Any idea what could cause this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet