Logging cleanup #452
Merged
Logging cleanup #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleans up logging output so that things that belong together stay together.
Currently, our logs are a bit inconsistent, with some being
`{e,}println!`s and others utilizing macros from the `log` crate. One
line might look like `INFO:ofborg::tasks::evaluate: Removing labels:
[]`, while the next might look like `Already: []`.
May as well be consistent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our logs are a bit inconsistent, with some being
{e,}println!s and others utilizing macros from thelogcrate. Oneline might look like
INFO:ofborg::tasks::evaluate: Removing labels: [], while the next might look likeAlready: [].My hope is that this will keep related logging together. There have been a few
ofborg-internal-errorslabeled recently, yet not showing up in the logs. If I'm lucky, this will alleviate that issue.Since the plan seems to be, in the long run, to switch to the
slogfamily of crates, this is more of a temporary solution.I didn't touch the
{e,}println!s inside tests because I didn't really see a point. Easily remedied, though, if preferred.