Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 5e7ccdc9e3dd
Choose a base ref
...
head repository: NixOS/nix
compare: ebb20a5356af
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Apr 5, 2020

  1. Don't retry on "unsupported protocol" error 

    When encountering an unsupported protocol, there's no need to retry.
Chances are, it won't suddenly be supported between retry attempts;
error instead. Otherwise, you see something like the following:

    $ nix-env -i -f git://git@github.com/foo/bar
    warning: unable to download 'git://git@github.com/foo/bar': Unsupported protocol (1); retrying in 335 ms
    warning: unable to download 'git://git@github.com/foo/bar': Unsupported protocol (1); retrying in 604 ms
    warning: unable to download 'git://git@github.com/foo/bar': Unsupported protocol (1); retrying in 1340 ms
    warning: unable to download 'git://git@github.com/foo/bar': Unsupported protocol (1); retrying in 2685 ms

With this change, you now see:

    $ nix-env -i -f git://git@github.com/foo/bar
    error: unable to download 'git://git@github.com/foo/bar': Unsupported protocol (1)
    @cole-h
    cole-h committed Apr 5, 2020
    Copy the full SHA
    c976cb0 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Merge pull request #3474 from cole-h/error-on-unsupported-protocol 

    Don't retry on "unsupported protocol" error
    @edolstra
    edolstra committed Apr 6, 2020
    Copy the full SHA
    ebb20a5 View commit details
    Browse the repository at this point in the history