Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana-loki: 1.3.0 -> 1.4.0 #84439

Merged
merged 1 commit into from Apr 6, 2020
Merged

grafana-loki: 1.3.0 -> 1.4.0 #84439

merged 1 commit into from Apr 6, 2020

Conversation

JJJollyjim
Copy link
Member

@JJJollyjim JJJollyjim commented Apr 6, 2020 •
edited

Motivation for this change

https://github.com/grafana/loki/releases/tag/v1.4.0

Things done

Just updated :)

This update requires a config change in certain circumstances, do I need to document that somewhere? https://github.com/grafana/loki/blob/master/docs/operations/upgrade.md

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from mmahut, WilliButz and globin April 6, 2020 06:52
@Ma27 Ma27 merged commit 32e7c0f into NixOS:master Apr 6, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 6, 2020

@WilliButz should we backport this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmahut mmahut Awaiting requested review from mmahut

@WilliButz WilliButz Awaiting requested review from WilliButz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JJJollyjim @Ma27