Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musikcube: init at 0.90.1 #84348

Merged
merged 1 commit into from Apr 24, 2020
Merged

musikcube: init at 0.90.1 #84348

merged 1 commit into from Apr 24, 2020

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 5, 2020 •
edited

Motivation for this change

#84318

Things not yet done
  • test (beyond ensuring this compiles and runs, I didn't even test that there was audio output 🤷‍♂️)
  • find a maintainer *nudge* @evertedsphere *nudge* 🤷‍♂️
  • ensure it actually compiles on darwin (I have no access to a mac)
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Apr 5, 2020 •
edited

@GrahamcOfBorg build musikcube

@evertedsphere
Copy link

haha @aanderse thank you so much, but, erm. i was interested in trying this out, it does play audio, but... it seems to play back with regular, noticeable lag on my system that I couldn't fix or find any information on :(

@aanderse
Copy link
Member Author

aanderse commented Apr 7, 2020

haha @aanderse thank you so much, but, erm. i was interested in trying this out, it does play audio, but... it seems to play back with regular, noticeable lag on my system that I couldn't fix or find any information on :(

Sorry to hear that. I just gave it a quick test and everything worked fine.

@aanderse aanderse requested a review from jtojnar April 18, 2020 15:42
@aanderse aanderse changed the title musikcube: init at 0.83.0 musikcube: init at 0.90.1 Apr 21, 2020
@aanderse aanderse requested a review from jtojnar April 24, 2020 01:10
@aanderse aanderse merged commit 78250e8 into NixOS:master Apr 24, 2020
@aanderse aanderse deleted the musikcube branch April 24, 2020 12:27
@aanderse
Copy link
Member Author

As always thanks for the wonderful review @jtojnar 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @evertedsphere @jtojnar