Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

babashka: 0.0.78 -> 0.0.89 #84350

Merged
merged 3 commits into from Apr 27, 2020
Merged

babashka: 0.0.78 -> 0.0.89 #84350

merged 3 commits into from Apr 27, 2020

Conversation

bennyandresen
Copy link
Contributor

Motivation for this change

Version bump

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@AndersonTorres

@ofborg ofborg bot requested a review from jlesquembre April 5, 2020 13:07
@bhougland18
Copy link
Contributor

Thanks @BAndresen! I just saw this yesterday. This version has some big enhancements.

@FRidh
Copy link
Member

FRidh commented Apr 5, 2020

@GrahamcOfBorg build babashka

1 similar comment
@FRidh
Copy link
Member

FRidh commented Apr 5, 2020

@GrahamcOfBorg build babashka

@bhougland18
Copy link
Contributor

Any possibility to bump it to 0.0.8 instead?

@bennyandresen bennyandresen changed the title babashka: 0.0.78 -> 0.0.79 babashka: 0.0.78 -> 0.0.80 Apr 7, 2020
@bennyandresen
Copy link
Contributor Author

bennyandresen commented Apr 7, 2020 •
edited

I still don't know why @GrahamcOfBorg doesn't build this (or clj-kondo) but it compiles fine on my system.

@bennyandresen
Copy link
Contributor Author

Maybe @GrahamcOfBorg doesn't try to build because graalvm8 has not been build successfully hydra in quite awhile. (Got this from a comment in #84354 by @jlesquembre

@bennyandresen bennyandresen mentioned this pull request Apr 7, 2020
Closed
@bennyandresen
Copy link
Contributor Author

for the next reviewer:

according to @hlolli in #83080 the package can't be built because it gets OOM-killed in grahamofborg's build.
I measured the peak memory resource consumption at 25GB when I built it myself.

It builds fine on my system and could be included, as the situation is the same for 0.0.78 or 0.0.71 before it.

@bennyandresen bennyandresen changed the title babashka: 0.0.78 -> 0.0.80 babashka: 0.0.78 -> 0.0.88-2 Apr 21, 2020
@bennyandresen
Copy link
Contributor Author

Updated to latest available babashka version at this point in time (0.0.88-2)

@bennyandresen bennyandresen mentioned this pull request Apr 21, 2020
Closed
10 tasks
@bennyandresen
Copy link
Contributor Author

Also pushed a commit for the utf-8 error that was found and fixed by @bfortz in #85393

@hlolli
Copy link
Member

hlolli commented Apr 21, 2020

4wiw, I'm still working hard on getting graalvm8/11 working on v20. These statically compiled .a libraries needed to run the jvmci8 is giving me a very hard time. But I hope to have a PR open soon.

@hlolli
Copy link
Member

hlolli commented Apr 21, 2020

Sorry not jvmci8, but substratevm expects jdk home with jvmci8 (in graal8's case) with .a libraries, and those have to come from jdk8 hotspot. With oracle using their own build farm to produce these files (ref. graalvm/openjdk8-jvmci-builder#11 ) it makes this bit difficult path to get right.

@bennyandresen bennyandresen changed the title babashka: 0.0.78 -> 0.0.88-2 babashka: 0.0.78 -> 0.0.89 Apr 24, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/137

@bennyandresen
babashka: increase java heap space max to 4500
f6ee88f 
3g has very long build times and also doesn't build 100% of the time
it's also the new default since:
babashka/babashka@7fc33dc
@Mic92
Copy link
Member

Mic92 commented Apr 27, 2020

Result of nixpkgs-review pr 84350 1

1 package built:
- babashka

@Mic92 Mic92 merged commit bd282ba into NixOS:master Apr 27, 2020
@bennyandresen bennyandresen deleted the babashka_0.0.78->0.0.79 branch May 20, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlesquembre jlesquembre Awaiting requested review from jlesquembre

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@bennyandresen @bhougland18 @FRidh @hlolli @nixos-discourse @Mic92