Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openblas: Add singleThreaded option. Off by default. #84382

Merged
merged 1 commit into from Apr 8, 2020
Merged

openblas: Add singleThreaded option. Off by default. #84382

merged 1 commit into from Apr 8, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Apr 5, 2020 •
edited

Motivation for this change

In many cases (when called from a program / programming language runtime that uses threads, see OpenMathLib/OpenBLAS#2543 and linked wiki) OpenBLAS needs to be used single-threadedly.

This adds a package flag that allows building it single-threadedly as described in the OpenBLAS wiki.

The default remains unchanged, so no eval differences.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nh2 nh2 requested a review from dtzWill April 5, 2020 19:11
@nh2 nh2 self-assigned this Apr 5, 2020
@nh2 nh2 requested a review from ttuegel April 5, 2020 19:12
@nh2
Copy link
Contributor Author

nh2 commented Apr 5, 2020

FYI @basvandijk @markuskowa @tobim

ttuegel
ttuegel requested changes Apr 8, 2020
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I have one suggestion below.

pkgs/development/libraries/science/math/openblas/default.nix Outdated Show resolved Hide resolved
@nh2 nh2 force-pushed the openblas-add-singleThreaded-option branch from 4cb0881 to df907c4 Compare April 8, 2020 11:46
@nh2 nh2 merged commit f3cf0f0 into NixOS:master Apr 8, 2020
@nh2
Copy link
Contributor Author

nh2 commented Apr 8, 2020

@ttuegel thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees

@nh2 nh2

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nh2 @ttuegel