Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rockbox-utility: add wrapQtAppsHook #84450

Merged
merged 1 commit into from Apr 6, 2020
Merged

rockbox-utility: add wrapQtAppsHook #84450

merged 1 commit into from Apr 6, 2020

Conversation

akhramov
Copy link
Contributor

@akhramov akhramov commented Apr 6, 2020 •
edited

It seems like all QT apps which use dynamic plugins should be wrapped
with wrapQtAppsHook. However, rockbox-utility is still not wrapped,
therefore fails to launch.

This change adds qt5.wrapQtAppsHook to nativeBuildInputs of
rockbox-utility.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@akhramov
rockbox-utility: add wrapQtAppsHook
861df8a 
It seems like all QT apps which use dynamic plugins should be wrapped
with `wrapQtAppsHook`. However, rockbox-utility is still not wrapped,
therefore fails to launch.

This change adds `qt5.wrapQtAppsHook` to nativeBuildInputs of
rockbox-utility.
@ofborg ofborg bot requested a review from cillianderoiste April 6, 2020 09:35
@Mic92 Mic92 merged commit 5af0a6c into NixOS:master Apr 6, 2020
@Mic92
Copy link
Member

Mic92 commented Apr 6, 2020

also backported:

[detached HEAD 10d60f7] rockbox-utility: add wrapQtAppsHook
Author: Artem Khramov akhramov@pm.me
Date: Mon Apr 6 14:04:33 2020 +0600
1 file changed, 2 insertions(+), 2 deletions(-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@akhramov @Mic92 @Janik-Haag