powershell: 6.2.3 -> 7.0.0 #84454
Closed
powershell: 6.2.3 -> 7.0.0 #84454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package and openssl dependency version bump and cascading changes.
|
@jonringer @yrashk Please review if you have time. |
|
@GrahamcOfBorg build powershell |
jonringer
approved these changes
Apr 6, 2020
jonringer
reviewed
Apr 6, 2020
Comment on lines
+35
to
+39
| rm $pslibs/libcrypto.so.1.0.0 | ||
| rm $pslibs/libssl.so.1.0.0 | ||
|
|
||
| patchelf --replace-needed libcrypto.so.1.0.0 libcrypto.so.1.1 $pslibs/libmi.so | ||
| patchelf --replace-needed libssl.so.1.0.0 libssl.so.1.1 $pslibs/libmi.so |
There was a problem hiding this comment.
do you mind making this darwin compatible?
rm: cannot remove '/nix/store/kca66mmwd5sakpa836hmcdz1dqj260ms-powershell-7.0.0/share/powershell/libcrypto.so.1.0.0': No such file or directory
builder for '/nix/store/a3yv0rvwf11jms0i3h5466ph7kmcwfwg-powershell-7.0.0.drv' failed with exit code 1
error: build of '/nix/store/a3yv0rvwf11jms0i3h5466ph7kmcwfwg-powershell-7.0.0.drv' failed
There was a problem hiding this comment.
I thought autoPatchelfHook does not exists on macOS at all.
There was a problem hiding this comment.
Nevertheless the patchelf code needs to be hidden behind a optionalString !stdenv.isDarwin flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Package and openssl dependency version bump and cascading changes.
Motivation for this change
Version bump
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)