Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gtk3: 3.24.14 -> 3.24.17 #84367

Merged
merged 1 commit into from Apr 6, 2020
Merged

gtk3: 3.24.14 -> 3.24.17 #84367

merged 1 commit into from Apr 6, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Apr 5, 2020 •
edited

Motivation for this change

Hopefully fixes clipboard related crashes on wayland (I'm still seeing firefox/evince crash sometimes).

news: https://gitlab.gnome.org/GNOME/gtk/-/blob/3.24.17/NEWS

Things done

Built on top of staging next.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli flokli requested a review from andir April 5, 2020 18:29
@cole-h
Copy link
Member

cole-h commented Apr 5, 2020 •
edited

@GrahamcOfBorg eval

Eval seems to have gotten stuck. Let's try again.

EDIT: Purple label bad. Investigating.

EDIT2: Appears to be resolved...

jtojnar
jtojnar approved these changes Apr 5, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look okay.

@hedning hedning merged commit 91a20da into NixOS:staging Apr 6, 2020
@hedning hedning deleted the gtk-bump branch April 6, 2020 00:19
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jun 3, 2020
@hedning @dtzWill
gtk3: 3.24.14 -> 3.24.17 (NixOS#84367)
12224c4 
(cherry picked from commit 91a20da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@andir andir Awaiting requested review from andir

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@vcunat vcunat Awaiting requested review from vcunat

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @cole-h @jtojnar