Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.03] ceph 14.2.6 -> 14.2.8 #84431

Merged
merged 3 commits into from Apr 14, 2020
Merged

[20.03] ceph 14.2.6 -> 14.2.8 #84431

merged 3 commits into from Apr 14, 2020

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Apr 6, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

srhb added 3 commits April 6, 2020 07:49
@srhb
ceph: 14.2.6 -> 14.2.7
ee47f52 
(cherry picked from commit 41547d1)
@srhb
ceph: 14.2.7 -> 14.2.8
74ee45c 
(cherry picked from commit ec21f70)
@srhb
nixos/tests/ceph: Fix pg number to power of 2
637325d 
(cherry picked from commit 6ccd347)
@srhb
Copy link
Contributor Author

srhb commented Apr 6, 2020

Building locally atop 20.03 and running the tests before proceeding

@grahamc
Copy link
Member

grahamc commented Apr 6, 2020

@GrahamcOfBorg eval

@ofborg ofborg bot added the 6.topic: nixos label Apr 6, 2020
@ofborg ofborg bot requested review from krav, adevress and johanot April 6, 2020 11:40
@srhb
Copy link
Contributor Author

srhb commented Apr 6, 2020

single- and multi-node tests also succeed on this branch. Should be good to go.

@worldofpeace worldofpeace merged commit e5ba0c5 into NixOS:release-20.03 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krav krav Awaiting requested review from krav

@adevress adevress Awaiting requested review from adevress

@johanot johanot Awaiting requested review from johanot

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@srhb @grahamc @worldofpeace