Fix flaky cache-storage-reporting.https.html #22360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 20, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2112556
branch
2 times, most recently
from
eb82e03
to
c66ae98
Compare
The test is flaky, because it rely on a 4s timeout. This is not enough always enough. This patch splits this test into 4. One for every execution context: - Document - ServiceWorker - DedicatedWorker - SharedWorker This allows the timeout to become 'infinite', while still making sure the passing tests are still executed. Currently, only the SharedWorker hasn't been implemented yet. As a result it is marked as [ Timeout ] Bug: 1061029 Change-Id: If9a8e7b65d91cccffeeedb3f1a13d5e6e32e41bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112556 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#752410}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2112556
branch
from
c66ae98
to
3a9266b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test is flaky, because it rely on a 4s timeout. This is not enough
always enough.
This patch splits this test into 4. One for every execution context:
This allows the timeout to become 'infinite', while still making sure
the passing tests are still executed. Currently, only the SharedWorker
hasn't been implemented yet. As a result it is marked as [ Timeout ]
Bug: 1061029
Change-Id: If9a8e7b65d91cccffeeedb3f1a13d5e6e32e41bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112556
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752410}