Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connectors and switches #54

Closed
wants to merge 1 commit into from
Closed

Conversation

x44203
Copy link
Contributor

@x44203 x44203 commented Mar 20, 2020

No description provided.

@whitequark
Copy link
Member

Thanks for the PR. This board uses different I/O standards for some resources depending on the board configuration (which in this case is done by soldering some resistors). nMigen provides a way to handle this so that people with non-default configuration can use the same platform definition rather than having to change it; take a look at the Atlys board file to see how it works.

It would be ideal if you submitted a separate PR that adds the LED/switch resources on their own with the variable I/O banks so it could be more conveniently reviewed. The connector changes just need a second pair of eyes, so that's a bit easier.

@whitequark
Copy link
Member

Superseded by #56.

@whitequark whitequark closed this Mar 20, 2020
rroohhh pushed a commit to rroohhh/nmigen-boards that referenced this pull request Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants