Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #8039: [AI/GS] SetOrderFlags and GetOrderDestination didn't work for oil rigs #8040

Merged
merged 1 commit into from Mar 30, 2020
Merged

Fix #8039: [AI/GS] SetOrderFlags and GetOrderDestination didn't work for oil rigs #8040

merged 1 commit into from Mar 30, 2020

Conversation

SamuXarick
Copy link
Contributor

No description provided.

@glx22
Copy link
Contributor

glx22 commented Mar 20, 2020 •
edited

Maybe just replacing IsDockTile(t) with IsDockingTile(t) could work (not tested, just a guess)

Edit: or replace the full test with IsDockingTile(t) && IsShipDestinationTile(t, st->index)

@SamuXarick
Copy link
Contributor Author

Maybe just replacing IsDockTile(t) with IsDockingTile(t) could work (not tested, just a guess)

Edit: or replace the full test with IsDockingTile(t) && IsShipDestinationTile(t, st->index)

No, it's not the docking tile it wants, it's the dock itself

@LordAro LordAro added the backport requested This PR should be backport to current release (RC / stable) label Mar 24, 2020
@nielsmh nielsmh merged commit 4d4005d into OpenTTD:master Mar 30, 2020
@LordAro LordAro added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 31, 2020
@SamuXarick SamuXarick deleted the SetOrderFlags-missing-oil-rig-check branch December 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LordAro LordAro LordAro approved these changes

Assignees
No one assigned
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SamuXarick @glx22 @LordAro @nielsmh