Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hplip: Fix plugin url and hash #78257

Merged
merged 1 commit into from Jan 22, 2020
Merged

hplip: Fix plugin url and hash #78257

merged 1 commit into from Jan 22, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jan 22, 2020

Motivation for this change

The latest version of the plugin is not available from openprinting.org, therefore installation of hplipWithPlugin broke in #76128. This fixes this by switching to a download URL provided by HP.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz requested review from Mic92 and ttuegel January 22, 2020 09:33
@flokli
Copy link
Contributor

flokli commented Jan 22, 2020

This is probably nicer than #78023, WDYT @Kiwi ?

@flokli flokli merged commit 051c3e3 into NixOS:master Jan 22, 2020
@flokli flokli mentioned this pull request Jan 22, 2020
Closed
10 tasks
@Kiwi
Copy link
Member

Kiwi commented Jan 22, 2020

It's what I would have done if I had checked that link for this version and not the one that was deleted so I would know it worked. ;P So fine by me. Too late now anyway 😄

@talyz talyz deleted the hplip-plugin branch January 23, 2020 16:15
@jerith666
Copy link
Contributor

I get the following error trying to build this:

hash mismatch in fixed-output derivation '/nix/store/dizy1x4xhxs53wzzr77x9h39nm2pjv92-hplip-3.19.6-plugin.run':
  wanted: sha256:1fn8h1a5znjqjh071ifjdywr0xswc14286gwy6h9vvlh8hzrz347
  got:    sha256:1b5gys04kh41gg7r7rzlpdbc2f4jirl2ik22cd935mm85k7abfwq

@talyz
Copy link
Contributor Author

talyz commented Jan 25, 2020

@jerith666 Hm, your system is trying to build the old version with the new hash, for some reason...

@jerith666
Copy link
Contributor

Oh, thanks -- you're right! That's because I'd reverted the commit from #76128. I'd assumed I'd get a git conflict when the right fix for that came along, but turns out it touched different parts of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@talyz @flokli @Kiwi @jerith666