safety: init at 1.8.5 #78258
Closed
safety: init at 1.8.5 #78258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build python3Packages.dparse safety |
|
@GrahamcOfBorg eval |
jonringer
reviewed
Jan 24, 2020
| pname = "dparse"; | ||
| version = "0.4.1"; | ||
|
|
||
| buildInputs = [ six pyyaml packaging ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ six pyyaml packaging ]; | |
| propagatedBuildInputs = [ six pyyaml packaging ]; |
Comment on lines
+18
to
+21
| src = fetchPypi { | ||
| inherit pname version; | ||
| sha256 = "06bvn7m3xlfvw0l6ydm3b503ycsvj120sq7kkcayaa86j3xgv980"; | ||
| }; |
There was a problem hiding this comment.
usually src is order immediately after version. E.g:
pname = "dparse";
version = "0.4.1";
src = fetchPypi {
inherit pname version;
sha256 = "06bvn7m3xlfvw0l6ydm3b503ycsvj120sq7kkcayaa86j3xgv980";
};
...
| @@ -0,0 +1,29 @@ | |||
| { stdenv, python3Packages }: | |||
There was a problem hiding this comment.
generally the interpreter is what you want to import, in case you need to freeze some dependency version, this is done at the interpreter level.
Suggested change
| { stdenv, python3Packages }: | |
| { stdenv, python3 }: |
There was a problem hiding this comment.
the package set can be accessed with python3.pkgs
jonringer
reviewed
Jan 24, 2020
Comment on lines
+15
to
+16
| # Inpure integration tests | ||
| doCheck = false; |
There was a problem hiding this comment.
you can ignore specific tests with pytest. It's still good to include unit tests:
checkPhase = ''
pytest --ignore=some_file.py -k 'not bad_test'
|
Thank you for the feedback. I do not longer needs this to be included. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
safety: init at 1.8.5
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)