Formspec: Don't start a button click when the pointer isn't on top (#…

…9332)
minetest · Jan 22, 2020 · 3dfb6ec · 3dfb6ec
1 parent 0877587
commit 3dfb6ec
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/gui/guiButton.cpp b/src/gui/guiButton.cpp
@@ -203,8 +203,12 @@ bool GUIButton::OnEvent(const SEvent& event)
 	case EET_MOUSE_INPUT_EVENT:
 		if (event.MouseInput.Event == EMIE_LMOUSE_PRESSED_DOWN)
 		{
-			if (!IsPushButton)
+			// Sometimes formspec elements can receive mouse events when the
+			// mouse is outside of the formspec. Thus, we test the position here.
+			if ( !IsPushButton && AbsoluteClippingRect.isPointInside(
+						core::position2d<s32>(event.MouseInput.X, event.MouseInput.Y ))) {
 				setPressed(true);
+			}
 
 			return true;
 		}