Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enum4linux: init at 0.8.9 #78311

Merged
merged 2 commits into from Jan 25, 2020
Merged

enum4linux: init at 0.8.9 #78311

merged 2 commits into from Jan 25, 2020

Conversation

fishi0x01
Copy link
Member

@fishi0x01 fishi0x01 commented Jan 22, 2020 •
edited

Motivation for this change

enum4linux is a perl script for smb enumeration.
Basically it is a wrapper script around rpcclient, net, nmblookup and smbclient (those are provided by the smbclient package as far as I can see).
It also ships as package for Kali Linux.

Things done

This is my first package - so I am pretty sure that there are a lot of enhancements possible.

Successfully build/installed on Ubuntu18.04 via:

$ nix-env -f $NIXPKGS -iA enum4linux

After installation I could successfully run enum4linux. I do have smbclient installed through nixpkgs, which provides the underlying tools that are used by enum4linux.
Ideally, samba and perl are added as a runtime dependency, but I am not sure if I am doing that properly.

@fishi0x01 fishi0x01 force-pushed the fishi0x01/enum4linux branch 5 times, most recently from a6d0be4 to 90e0b6a Compare January 23, 2020 15:42
aanderse
aanderse requested changes Jan 24, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fishi0x01! I'm glad you chose to contribute to nixpkgs.

I have provided a few comments which I hope are helpful. If at any point you want some clarification on what I have said please don't hesitate to ask.

Welcome to the maintainer team! 🎉

pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
@fishi0x01 fishi0x01 force-pushed the fishi0x01/enum4linux branch 2 times, most recently from 7568ebe to 979fb02 Compare January 24, 2020 21:03
@fishi0x01
Copy link
Member Author

Thx a lot @aanderse for the great and detailed advice! I learned a lot from that :)

Especially

wrapProgram $out/bin/enum4linux.pl \
      --prefix PATH : ${stdenv.lib.makeBinPath [ openldap samba ]}

is a really nice piece of magic. It helps me with another package I am currently struggling with.

Does the PR look better now?

aanderse
aanderse requested changes Jan 25, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there. Looking good 👍

pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/enum4linux/default.nix Outdated Show resolved Hide resolved
@fishi0x01 fishi0x01 force-pushed the fishi0x01/enum4linux branch 2 times, most recently from 1b16430 to 54a188c Compare January 25, 2020 08:23
@fishi0x01
Copy link
Member Author

Alright, thx for input 👍
I committed the suggested changes.

@aanderse
Copy link
Member

@fishi0x01 perfect except for the final thing I forgot to mention... sorry! Please split this into 2 separate commits: first commit is adding yourself to the maintainers list, the second commit being the rest.

@fishi0x01
Copy link
Member Author

@aanderse No problem :)
Split into 2 commits. Does that work for you?

@aanderse
Copy link
Member

aanderse commented Jan 25, 2020 •
edited

Perfect! We'll let the bot do it's thing and then merge. Thanks for your work, and again... welcome to the team! :tada!

@aanderse aanderse merged commit ea87d5f into NixOS:master Jan 25, 2020
@fishi0x01 fishi0x01 deleted the fishi0x01/enum4linux branch January 25, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fishi0x01 @aanderse