Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: ab10bac1b177
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 0daae2e08c1b
Choose a head ref
  • 1 commit
  • 2 files changed
  • 1 contributor

Commits on Jan 21, 2020

  1. nixos/buildkite: drop user option (#78160) 

    * nixos/buildkite: drop user option

This reverts 8c6b1c3.

Turns out, buildkite-agent has logic to write .ssh/known_hosts files and
only really works when $HOME and the user homedir are in sync.

On top of that, we provision ssh keys in /var/lib/buildkite-agent, which
doesn't work if that other users' homedir points elsewhere (we can cheat
by setting $HOME, but then getent and $HOME provide conflicting
results).

So after all, it's better to only run the system-wide buildkite agent as
the "buildkite-agent" user only - if one wants to run buildkite as
different users, systemd user services might be a better fit.

* nixosTests.buildkite-agent: add node with separate user and no ssh key
    @flokli @zimbatm
    flokli authored and zimbatm committed Jan 21, 2020
    Configuration menu
    Copy the full SHA
    0daae2e View commit details
    Browse the repository at this point in the history