Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.django-auth-ldap: update django dependency #78255

Merged
merged 1 commit into from Jan 22, 2020
Merged

pythonPackages.django-auth-ldap: update django dependency #78255

merged 1 commit into from Jan 22, 2020

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Package django-auth-ldap' requires Django 1.11+ which package django' already satisfies. With this change, this package can be used together with other Django packages without having to override attributes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pythonPackages.django-auth-ldap: update django dependency
b90325b 
Package `django-auth-ldap' requires Django 1.11+ which package `django' satisfies.
jonringer
jonringer approved these changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff/commit LGTM

[3 built, 3 copied (1.7 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/78255
2 package built:
python37Packages.django-auth-ldap python38Packages.django-auth-ldap

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.django-auth-ldap python38Packages.django-auth-ldap

@jonringer jonringer merged commit 37298b5 into NixOS:master Jan 22, 2020
@ofborg ofborg bot requested a review from mmai January 22, 2020 08:59
@WorldQuantOS WorldQuantOS deleted the wq_django-auth-ldap branch January 22, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@mmai mmai Awaiting requested review from mmai

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnoldfarkas @jonringer