Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard: 1.0.20200102 -> 1.0.20200121 #78191

Merged
merged 2 commits into from Jan 22, 2020
Merged

wireguard: 1.0.20200102 -> 1.0.20200121 #78191

merged 2 commits into from Jan 22, 2020

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Jan 21, 2020 •
edited

Motivation for this change

https://lists.zx2c4.com/pipermail/wireguard/2020-January/004870.html
https://lists.zx2c4.com/pipermail/wireguard/2020-January/004869.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 21, 2020
@Ma27 Ma27 requested review from fpletz, elseym and d-xo January 21, 2020 17:10
@Ma27 Ma27 changed the title Bump wireguard wireguard: 1.0.20200102 -> 1.0.20200121 Jan 21, 2020
@ofborg ofborg bot requested review from Mic92 and globin January 21, 2020 17:50
@fpletz
Copy link
Member

fpletz commented Jan 21, 2020

@GrahamcOfBorg test wireguard wireguard-generated wireguard-namespaces

d-xo
d-xo approved these changes Jan 21, 2020
View reviewed changes
Copy link
Contributor

@d-xo d-xo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@globin globin merged commit 0751c48 into NixOS:master Jan 22, 2020
@Ma27 Ma27 deleted the bump-wireguard branch January 22, 2020 20:31
@Ma27
Copy link
Member Author

Ma27 commented Jan 22, 2020

Also backported as d3c4839, ada9712.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 22, 2020
@d-xo
Copy link
Contributor

d-xo commented Jan 25, 2020

Does it start working again if you downgrade wireguard on that server?

@Mic92
Copy link
Member

Mic92 commented Jan 25, 2020 •
edited

That should be also reported upstream on the wireguard mailing list.

@Ma27
Copy link
Member Author

Ma27 commented Jan 26, 2020

As I don't own any AMD hardware, I asked @fpletz if he could reproduce this. Apart from this it would be good to file a bugreport to upstream.

Unless we already have a patch which may fix the issue, I'm also considering a revert of the update on release-19.09.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-xo d-xo d-xo approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@elseym elseym Awaiting requested review from elseym

@Mic92 Mic92 Awaiting requested review from Mic92

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Ma27 @fpletz @d-xo @Mic92 @globin