Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gavrasm: init at 4.5 #78217

Merged
merged 1 commit into from Jan 24, 2020
Merged

gavrasm: init at 4.5 #78217

merged 1 commit into from Jan 24, 2020

Conversation

MarcFontaine
Copy link
Contributor

Motivation for this change

This PR adds the gavrasm AVR assembler to nixpkgs.
This assembler is used in several AVR projects and tutorials.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

bjornfor
bjornfor reviewed Jan 24, 2020
View reviewed changes
pkgs/development/compilers/gavrasm/default.nix Outdated
license = licenses.unfree;
maintainers = with maintainers; [ mafo ];
platforms = platforms.linux;
inherit version;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the point of having meta.version? (The version attribute is already accessible via the derivation.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK Thx, I changed it.. (meta.version was in the default.nix I used as template (but that maybe wrong))

@bjornfor bjornfor merged commit 3958cc3 into NixOS:master Jan 24, 2020
@MarcFontaine MarcFontaine deleted the gavrasm branch January 25, 2020 11:40
@MarcFontaine
Copy link
Contributor Author

@bjornfor Thx for the review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MarcFontaine @bjornfor