Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdiskreport: cleanup and add desktop item #78193

Merged
merged 2 commits into from Feb 10, 2020
Merged

jdiskreport: cleanup and add desktop item #78193

merged 2 commits into from Feb 10, 2020

Conversation

kylesferrazza
Copy link
Member

Motivation for this change

No desktop entry for JDiskReport.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kylesferrazza
Copy link
Member Author

  • added a desktop item
  • inlined the install script
  • added myself to the maintainers array

@FRidh FRidh merged commit 2843a7d into NixOS:master Feb 10, 2020
@kylesferrazza kylesferrazza deleted the jdiskreport-desktop-file branch February 10, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kylesferrazza @FRidh