Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pantalaimon: init at 0.4 #78226

Merged
merged 2 commits into from Feb 14, 2020
Merged

pantalaimon: init at 0.4 #78226

merged 2 commits into from Feb 14, 2020

Conversation

Valodim
Copy link
Contributor

@Valodim Valodim commented Jan 22, 2020

Motivation for this change

Packaging pantalaimon :)

Things done

Straightforward packaging, nothing out of the ordinary. All dependencies were available.

One thing of note, though: during nixpkgs-review I received this seemingly unrelated error while testing asynctest with python3.8. Not sure what that is about?:

builder for '/nix/store/19rjmv99i3w4n6bsc8v2wmx2g18qqjsn-python3.8-asynctest-0.13.0.drv' failed with exit code 1; last 10 log lines:
    File "/nix/store/r9zas1x2nv9bn505hq6323171f5ik5ad-python3-3.8.1/lib/python3.8/asyncio/base_events.py", line 612, in run_until_complete
      return future.result()
    File "/build/asynctest-0.13.0/test/test_mock.py", line 1934, in tester
      self.assertFalse(fut.result())
  AssertionError: True is not false
  
  ----------------------------------------------------------------------
  Ran 219 tests in 0.530s
  
  FAILED (failures=6)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip" failed for python3.8, see above
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Valodim
Copy link
Contributor Author

Valodim commented Jan 22, 2020

ping @tilpner, who maintains some related packages

jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

https://github.com/NixOS/nixpkgs/pull/78226
1 package built:
pantalaimon

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/pantalaimon/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
executable shows usage

https://github.com/NixOS/nixpkgs/pull/78226
1 package built:
pantalaimon

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pantalaimon

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pantalaimon

jonringer
jonringer reviewed Jan 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently I was wrong. It looks like the test harness for darwin is broken, but not the actual package. Let's just disable tests for darwin as I fell confident that they should work in most situations.

pkgs/applications/networking/instant-messengers/pantalaimon/default.nix Outdated Show resolved Hide resolved
pkgs/applications/networking/instant-messengers/pantalaimon/default.nix Show resolved Hide resolved
@Valodim
Copy link
Contributor Author

Valodim commented Jan 28, 2020

All done. Thanks for your guidance!

@jonringer
Copy link
Contributor

@GrahamcOfBorg build pantalaimon

symphorien
symphorien approved these changes Feb 14, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on nixos, builds and is functional.

@jonringer
Copy link
Contributor

oops, forgot about this. LGTM

@jonringer jonringer merged commit a49b311 into NixOS:master Feb 14, 2020
@Valodim Valodim deleted the python-pantalaimon branch February 15, 2020 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@symphorien symphorien symphorien approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Valodim @jonringer @symphorien