New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pantalaimon: init at 0.4 #78226
pantalaimon: init at 0.4 #78226
Conversation
ping @tilpner, who maintains some related packages |
5c68d06
to
748096e
Compare
748096e
to
d09ab97
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
commit LGTM
https://github.com/NixOS/nixpkgs/pull/78226
1 package built:
pantalaimon
pkgs/applications/networking/instant-messengers/pantalaimon/default.nix
Outdated
Show resolved
Hide resolved
d09ab97
to
ea44c0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
diff LGTM
executable shows usage
https://github.com/NixOS/nixpkgs/pull/78226
1 package built:
pantalaimon
@GrahamcOfBorg build pantalaimon |
@GrahamcOfBorg build pantalaimon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apparently I was wrong. It looks like the test harness for darwin is broken, but not the actual package. Let's just disable tests for darwin as I fell confident that they should work in most situations.
pkgs/applications/networking/instant-messengers/pantalaimon/default.nix
Outdated
Show resolved
Hide resolved
7fc3ce6
to
acc89e8
Compare
All done. Thanks for your guidance! |
@GrahamcOfBorg build pantalaimon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on nixos, builds and is functional.
oops, forgot about this. LGTM |
Motivation for this change
Packaging pantalaimon :)
Things done
Straightforward packaging, nothing out of the ordinary. All dependencies were available.
One thing of note, though: during nixpkgs-review I received this seemingly unrelated error while testing asynctest with python3.8. Not sure what that is about?:
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
failed for python3.8, see above./result/bin/
)nix path-info -S
before and after)