Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not provide a defaulted reference_radius if no geopotential is present #2456

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

eggrobin
Copy link
Member

@eggrobin eggrobin commented Jan 22, 2020

See #2429 and its fix, #2430: if a principia_gravity_model.body node has no geopotential_row, geopotential is an empty array rather than a null in the affected code. This meant that we would provide a defaulted reference_radius to the C++, which would fail with

Check failed: body.has_j2() || body.has_geopotential() == body.has_reference_radius() (0 vs. 1)

even though the constraint

either reference_radius is absent, or one of j2 and geopotential_row is present;

was satisfied by the configuration.

@pleroy pleroy added the LGTM label Jan 22, 2020
@eggrobin eggrobin merged commit 407eade into mockingbirdnest:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants