Do not provide a defaulted reference_radius if no geopotential is present #2456
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2429 and its fix, #2430: if a
principia_gravity_model.body
node has nogeopotential_row
,geopotential
is an empty array rather than a null in the affected code. This meant that we would provide a defaultedreference_radius
to the C++, which would fail witheven though the constraint
was satisfied by the configuration.