Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mimesis: init at 3.3.0 #78297

Closed
wants to merge 1 commit into from
Closed

pythonPackages.mimesis: init at 3.3.0 #78297

wants to merge 1 commit into from

Conversation

arnoldfarkas
Copy link
Contributor

Motivation for this change

Adding Python package for mimesis.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

please add yourself as a maintainer, similar to this PR: #75561

@jonringer
Copy link
Contributor

seeing as you have many PRs open, you can open a new PR just adding yourself, and that can be merged very quickly, then the already open PRs can just be rebased on top of master to fix eval issues

@arnoldfarkas
Copy link
Contributor Author

arnoldfarkas commented Jan 24, 2020 via email

@jonringer
Copy link
Contributor

I apologize, I only get pinged for python related changes. And don't have the spare time to review everything else :(

@arnoldfarkas
Copy link
Contributor Author

No problem at all, it was just unfortunate that the above PR missed everyone's attention:)

@arnoldfarkas
Copy link
Contributor Author

Looks like the PR should be re-opened in order to re-trigger eval.

@arnoldfarkas arnoldfarkas reopened this Jan 24, 2020
@jonringer
Copy link
Contributor

You need to rebase on master anyway, and the force push will trigger an eval

git pull -r origin master
git push .. ... --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@arnoldfarkas @jonringer