Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cri-o: Fix build tags usage #78300

Merged
merged 1 commit into from Jan 22, 2020
Merged

cri-o: Fix build tags usage #78300

merged 1 commit into from Jan 22, 2020

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented Jan 22, 2020 •
edited

Motivation for this change

The build tags have been used wrongly and result in builds containing not the right feature sets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@saschagrunert
Copy link
Member Author

@GrahamcOfBorg build cri-o

@saschagrunert saschagrunert changed the title cri-o: Fix build tags usage WIP: cri-o: Fix build tags usage Jan 22, 2020
@saschagrunert
cri-o: Fix build tags usage
18c0964 
Signed-off-by: Sascha Grunert <sgrunert@suse.com>
@saschagrunert saschagrunert changed the title WIP: cri-o: Fix build tags usage cri-o: Fix build tags usage Jan 22, 2020
@ofborg ofborg bot requested a review from ehmry January 22, 2020 16:11
@ehmry ehmry merged commit b5035c0 into NixOS:master Jan 22, 2020
@saschagrunert saschagrunert deleted the cri-o-fix branch January 22, 2020 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry ehmry approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@saschagrunert @ehmry