Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pip: 19.3.1 -> 20.0.2 #78344

Merged
merged 1 commit into from Feb 10, 2020
Merged

python3Packages.pip: 19.3.1 -> 20.0.2 #78344

merged 1 commit into from Feb 10, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jan 23, 2020 •
edited

Motivation for this change

noticed a new version was released

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer requested a review from FRidh January 23, 2020 02:04
@jonringer
Copy link
Contributor Author

actually, hold off on this, there seems to be many issues with 20.0.1. Namely, pypa/pip#7626

@FRidh FRidh added this to WIP in Staging via automation Jan 29, 2020
@FRidh FRidh self-assigned this Jan 29, 2020
@jonringer
Copy link
Contributor Author

20.02 doesn't seem to have many major regressions, was able to build azure-cli (~300 packages) with it.

@jonringer jonringer changed the title python3Packages.pip: 19.3.1 -> 20.0.1 python3Packages.pip: 19.3.1 -> 20.0.2 Feb 10, 2020
@jonringer jonringer merged commit 5ca385e into NixOS:staging Feb 10, 2020
Staging automation moved this from WIP to Done Feb 10, 2020
@jonringer jonringer deleted the bump-pip branch February 10, 2020 03:29
@raboof raboof mentioned this pull request Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @FRidh