Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gjs: 1.58.3 -> 1.58.4 #78163

Merged
merged 1 commit into from Jan 21, 2020
Merged

gjs: 1.58.3 -> 1.58.4 #78163

merged 1 commit into from Jan 21, 2020

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/gjs/versions.

meta.description for gjs is: '"JavaScript bindings for GNOME"'.

meta.homepage for gjs is: '"https://gitlab.gnome.org/GNOME/gjs/blob/master/doc/Home.md"

Checks done (click to expand)
  • built on NixOS

  • Warning: a test defined in passthru.tests did not pass

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 1.58.4 with grep in /nix/store/gjam1ayazd8c654kiip4p5f6bysqjzx1-gjs-1.58.4

Rebuild report (if merged into master) (click to expand)

136 total rebuild path(s)

46 package rebuild(s)

46 x86_64-linux rebuild(s)
45 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
44 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
adapta-gtk-theme
buildah
chrome-gnome-shell
discover
flatpak
flatpak-builder
gjs
gnome-builder
gnome3.anjuta
gnome3.gjs
gnome3.gnome-books
gnome3.gnome-characters
gnome3.gnome-control-center
gnome3.gnome-documents
gnome3.gnome-maps
gnome3.gnome-session
gnome3.gnome-shell
gnome3.gnome-software
gnome3.gnome-sound-recorder
gnome3.gnome-terminal
gnome3.gnome-tweak-tool
gnome3.gnome-tweaks
gnome3.gnome-weather
gnome3.gnome_control_center
gnome3.gnome_session
gnome3.gnome_shell
gnome3.gnome_terminal
gnome3.gpaste
gnome3.polari
gnome3.pomodoro
gnome3.sushi
gnomeExtensions.drop-down-terminal
gnomeExtensions.gsconnect
gtkpod
haskellPackages.gi-ostree
minishift
nix-prefetch-docker
ostree
pantheon.appcenter
pantheon.elementary-session-settings
pantheon.sideload
plasma5.discover
rpm-ostree
skopeo
xdg-desktop-portal
xdg-desktop-portal-gtk

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/gjam1ayazd8c654kiip4p5f6bysqjzx1-gjs-1.58.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A gjs https://github.com/r-ryantm/nixpkgs/archive/899e000f73b802b8048d2bbea47f1aed58921ac9.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/gjam1ayazd8c654kiip4p5f6bysqjzx1-gjs-1.58.4
ls -la /nix/store/gjam1ayazd8c654kiip4p5f6bysqjzx1-gjs-1.58.4/bin

cc @lethalman @jtojnar @hedning @worldofpeace for testing.

@hedning
Copy link
Contributor

hedning commented Jan 21, 2020

NEWS:

Version 1.58.4

  • Now prints a warning when constructing an unregistered object inheriting from
    GObject (i.e. if you forgot to use GObject.registerClass.) In 1.58.2 this
    would throw an exception, which broke some existing code, so that change was
    reverted in 1.58.3. In this version the check is reinstated, but we log a
    warning instead of throwing an exception, so that people know to fix their
    code, but without breaking things.
    NOTE: In 1.64 (the next stable release) the warning will be changed back into
    an exception, because code with this problem can be subtly broken and cause
    unexpected errors elsewhere. So make sure to fix your code if you get this
    warning.

  • Closed bugs and merge requests:

    • GSettings crash fixes [Andy Holmes, !373]
  • Memory savings for Cairo objects [Philip Chimento, !374]

  • Fix for crash in debug functions [Philip Chimento, !374]

@hedning hedning self-assigned this Jan 21, 2020
@hedning
Copy link
Contributor

hedning commented Jan 21, 2020

The gnome3 test passes (I also tested running gnome-shell in a nested wayland session without problems.

@hedning hedning merged commit a055d4d into NixOS:master Jan 21, 2020
@r-ryantm r-ryantm deleted the auto-update/gjs branch January 25, 2020 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants