Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cinnamon.cinnamon-control-center: init at 4.4.0 #78328

Merged
merged 1 commit into from Jan 29, 2020

Conversation

mkg20001
Copy link
Member

Motivation for this change

Cinnamon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mkg20001 mkg20001 force-pushed the pkg/cinnamon-control-center branch 4 times, most recently from fca30fa to 6c077e5 Compare January 24, 2020 21:16
@worldofpeace
Copy link
Contributor

The packaging here looks good. but there's some issues we should still fix.

Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into it, and it seems they have something going on so it's only showing in cinnamon.
Same many other modules. So it's good to overlook for now.

@worldofpeace worldofpeace merged commit af9bb2a into NixOS:master Jan 29, 2020
anna328p pushed a commit to anna328p/nixpkgs that referenced this pull request Feb 2, 2020
cinnamon.cinnamon-control-center: init at 4.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants