Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit newly added dimensions" tries to allow editing auto-reference dimensions #536

Closed
rpavlik opened this issue Dec 23, 2019 · 3 comments
Closed

"Edit newly added dimensions" tries to allow editing auto-reference dimensions #536

rpavlik opened this issue Dec 23, 2019 · 3 comments
Labels
bug

Comments

@rpavlik
Copy link
Contributor

rpavlik commented Dec 23, 2019

System information

SolveSpace version: 3.0~64c0f62b

Operating system: Debian Buster

Expected behavior

I turned on "Edit newly added dimensions" because it's a great workflow improvement.

When adding a distance constraint on an already fully-constrained sketch, I'd expect it to not let me edit it, since solvespace will automatically mark such a constraint as "REF"

Actual behavior

It lets you "edit" it, though the edits have no effect.

Additional information

Peek 2019-12-20 11-02

Peek 2019-12-23 09-42

Here's the model for the second one,
example.zip
@whitequark whitequark added the bug label Dec 24, 2019
@vespakoen
Copy link
Contributor

I added that functionality and didn't think of this case.
I will try to make a PR when I've got some time on my hands

@whitequark
Copy link
Contributor

Thanks for following up!

@rpavlik
Copy link
Contributor Author

rpavlik commented Mar 7, 2020

Looks fixed since 3ed1719, thanks!

@rpavlik rpavlik closed this as completed Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@whitequark @rpavlik @vespakoen