Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grafana-loki: 1.2.0 -> 1.3.0, patch distributor test #78331

Merged
merged 1 commit into from Jan 22, 2020
Merged

grafana-loki: 1.2.0 -> 1.3.0, patch distributor test #78331

merged 1 commit into from Jan 22, 2020

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/grafana/loki/releases/tag/v1.3.0

Things done

Patched the distributor test to succeed in our build environment.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
grafana-loki: 1.2.0 -> 1.3.0, patch distributor test
96de24c 
Only include the loopback interface "lo" in the lifecycler configuration
of the distributor test.
@WilliButz WilliButz added the 9.needs: port to stable A PR needs a backport to the stable release. label Jan 22, 2020
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test loki

@ofborg ofborg bot requested review from globin, ehmry and mmahut January 22, 2020 23:08
@Ma27 Ma27 merged commit 9894a1b into NixOS:master Jan 22, 2020
@Ma27
Copy link
Member

Ma27 commented Jan 22, 2020

Thanks! Backported as 4931489.

To properly build this on release-19.09 (which seems to require go 1.13), I pushed a simple fix: a0fedb1

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 22, 2020
@WilliButz WilliButz deleted the update-loki branch January 23, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@globin globin Awaiting requested review from globin

@ehmry ehmry Awaiting requested review from ehmry

@mmahut mmahut Awaiting requested review from mmahut

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27