pythonPackages.dill: enable tests #78215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
6.topic: python
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
drewrisinger
force-pushed
the
dr-pr-dill-tests
branch
from
039e0e0
to
d8db97a
Compare
|
honestly, looking at the test suite, the original comment is pretty accurate. The test suite doesn't:
I would recommend AGAINST using a test suite for this package, and would probably go so far as to say you shouldn't use this package in production because of it's odd import behavior. For example, the imports begin to create cycles: |
|
Fair, but a different package I'm working on fixing (qiskit) requires it as
of October 2019 ish.
https://qiskit.org/documentation/release_notes.html
Relevant: dill <https://pypi.org/project/dill/> was added as a requirement.
This is needed to enable running passmanager.run() in parallel for more
than one circuit
Thoughts, since I'm locked into the upstream package requirements?
…On Tue, Jan 21, 2020, 6:50 PM Jon ***@***.***> wrote:
honestly, looking at the test suite, the original comment is pretty
accurate. The test suite doesn't:
- use a normal test runner like nose, pytest, or unittest
- ran in imperative manner
- few other things as well
I would recommend AGAINST using a test suite for this package, and would
probably go so far as to say you shouldn't use this package in production
because of it's odd import behavior. For example, the imports begin to
create cycles:
ImportError while importing test module '/build/dill-0.3.1.1/tests/test_module.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/nix/store/blf6jxfx5g36gp0yadm0ykr8h6fmif39-python3.7-dill-0.3.1.1/lib/python3.7/site-packages/dill/__diff.py:226: in _imp
mod = __import__(*args, **kwds)
tests/test_module.py:11: in <module>
import test_mixins as module
/nix/store/blf6jxfx5g36gp0yadm0ykr8h6fmif39-python3.7-dill-0.3.1.1/lib/python3.7/site-packages/dill/__diff.py:226: in _imp
mod = __import__(*args, **kwds)
E ModuleNotFoundError: No module named 'test_mixins'
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#78215?email_source=notifications&email_token=ACNZYI7BHSROM3RISRA63B3Q66C53A5CNFSM4KJ26DX2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJRWZ3Y#issuecomment-576941295>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACNZYI2ODXOHL4HSPKSSDDLQ66C53ANCNFSM4KJ26DXQ>
.
|
|
hard to say, really hurts this is also an upstream issue. |
|
if you really want the |
|
@jonringer @FRidh can you approve or reject? Strictly speaking, this PR at least runs SOME tests, even if the tests are messy. |
drewrisinger
force-pushed
the
dr-pr-dill-tests
branch
from
9e96585
to
e1a918b
Compare
|
Incorporated all suggestions. Builds locally. |
|
@GrahamcOfBorg build python3Packages.dill python2Packages.dill |
Thanks for your help! |
|
@GrahamcOfBorg build python3Packages.dill |
|
Maybe also disable python2 version? looks like build isn't working? |
|
@GrahamcOfBorg build python3Packages.dill |
jonringer
reviewed
Feb 13, 2020
Disable a few failing tests, see comments for what's failing.
drewrisinger
force-pushed
the
dr-pr-dill-tests
branch
from
e1a918b
to
215fac2
Compare
|
@jonringer done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tests in
pythonPackages.dillwere previously disabled. This enables most of the tests. Some tests were disabled, mostly because I tried to track down the errors and didn't have time to figure them out. Seems to maybe be some pathing/import issues from Nix.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)