Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sane-backends: 1.0.27 -> 1.0.28 #78198

Merged
merged 1 commit into from Jan 26, 2020
Merged

sane-backends: 1.0.27 -> 1.0.28 #78198

merged 1 commit into from Jan 26, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Jan 21, 2020

Motivation for this change

Update to version 1.0.28

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Jan 25, 2020

@GrahamcOfBorg build sane-backends sane-backends-git

@peti
Copy link
Member

peti commented Jan 26, 2020

I wish you'd just commit the version bump instead of re-arranging all kinds of attributes for no apparent reason. This makes the diff much harder to read. I display the changes expecting a two-line change, but instead there's almost no stone left unturned. :-(

@peti peti merged commit ba8fbd5 into NixOS:master Jan 26, 2020
@romildo romildo deleted the upd.sane branch January 26, 2020 10:09
@romildo
Copy link
Contributor Author

romildo commented Jan 26, 2020

@peti, sorry for making the changes difficult to read. You could have asked me to make them differently.

This version bump needed more changes besides the new version number and checksum though:

  • the upstream url has changed
  • there are new dependencies
  • some configure options have changed

Besides that I have also done the following with the intention to make it more readable and follow new trends I am seeing in too many nix expressions:

  • listed one dependence per line
  • put the dependence lists earlier
  • quoted the home url

Thanks for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants