Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mullvad VPN module #78199

Closed
wants to merge 2 commits into from
Closed

Mullvad VPN module #78199

wants to merge 2 commits into from

Conversation

spacekookie
Copy link
Member

There is already a mullvad package in nixpgks, but it wasn't very well
usable without some changes. I've also added a pretty simple module
to enable mullvad, without having to wrap the daemon manually.

I've been using this setup on my laptop for a while now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@spacekookie spacekookie changed the title ###### Motivation for this change Mullvad VPN module Jan 21, 2020
@KamilaBorowska
Copy link
Member

KamilaBorowska commented Jan 21, 2020 •
edited

This looks fine, and I agree with you mullvad is mostly useless without a service. There is kinda a duplication of work, because I'm still waiting for #70762 (a pull request I made long time ago for mullvad service) to be merged, but what can you do.

There are some parts I like more in your version (definitely usage of mkEnableOption, that much I can tell), and some parts I like better in my version, but I would need to spend some time to which parts are better in which PR (doesn't help I'm biased for my own PR, because I made it). Feel free to take a look at #70762, maybe it will provide some inspiration.

@spacekookie
Copy link
Member Author

spacekookie commented Jan 21, 2020 via email

@RafaelTaranto
Copy link

#70762 was merged already, this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@KamilaBorowska KamilaBorowska Awaiting requested review from KamilaBorowska

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@spacekookie @KamilaBorowska @RafaelTaranto