New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nixos/doc: Rudimentary documentation for Subversion-inside-Apache HTTP. #78168
nixos/doc: Rudimentary documentation for Subversion-inside-Apache HTTP. #78168
Conversation
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/how-to-set-up-subversion-http-server/5503/5 |
You will need to rebase on |
Rebased off master. Someone else needs to decide where it goes. I thought the idea was to move stuff off the wiki and onto maintained documentation? |
I marked this as stale due to inactivity. → More info |
This is kind of a bummer - it's s straightforward contribution, and I've been responsive to comments. |
@mikesperber you're very right. I'll review this again, familiarize myself with the documentation format, and merge it in the next few days. I'm very sorry for the delay. Maybe @Ma27 could find a few spare minutes to help me out by looking for any documentation format issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if the example would benefit from showing actual values instead of ...
🤔
I've revised the patch, but I want to verify it all works with the current NixOS tomorrow, when I have access to the physical machine. Please hold off re-review until then. |
@aanderse Done. Also checked the instructions against a fresh NixOS 20 install. Could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look. Will render this and view it to give a more full review shortly. Looking good though. Thanks!
@mikesperber the @Ma27 do you mind taking one more quick look, reading this over and making sure it works for you? The knowledge is a bit |
@AndersE Zapped the whitespace. Again, thanks! |
@mikesperber I hope this isn't getting too tiring for you... now the validation fails because it wants spaces, not tabs. Thanks again for your patience on this. |
Content thanks to: Aaron Andersen
@aanderse I hope it isn't getting too tiring for you. :-) Replaced the tabs by spaces. |
Thank you for your contribution and patience! |
@aanderse Thanks for the review & your patience! |
Content thanks to: Aaron Andersen
Motivation for this change
I couldn't figure out how to set up a Subversion WebDAV server. Aaron Anderson provided beautiful instructions, and I turned it into a documentation section.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)