Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmw-tes3mp: fix build #78312

Merged
merged 1 commit into from Feb 9, 2020
Merged

openmw-tes3mp: fix build #78312

merged 1 commit into from Feb 9, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2020

Motivation for this change

Fix build after #68029

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Jan 22, 2020

@GrahamcOfBorg build openmw-tes3mp

@aanderse
Copy link
Member

@gnidorah are thegcc 9 bugs being tracked upstream? Are there many?

PS. new openscenegraph will be out soon but minor release so shouldn't be impacting. I might ping you in #77799 for testing, if you don't mind.

@ghost
Copy link
Author

ghost commented Jan 23, 2020

@aanderse

are thegcc 9 bugs being tracked upstream? Are there many?

There are are errors:
/build/source/./apps/openmw-mp/Script/ScriptFunctions.hpp:153:5: error: 'constexpr ScriptFunctionPointer::ScriptFunctionPointer(Function<R, Types ...>) [with R = void; Types = {bool}; Function<R, Types ...> = void (*)(bool)]' called in a constant expression

They are not reported as I don't know the language. Maybe project author will do something.

PS. new openscenegraph will be out soon but minor release so shouldn't be impacting. I might ping you in #77799 for testing, if you don't mind.

Not necessary. @abbradar overrides osc source point in openmw derivation https://github.com/NixOS/nixpkgs/blob/master/pkgs/games/openmw/default.nix#L5 and I just reuse openmw package.

@aanderse
Copy link
Member

@gnidorah right I forgot about the custom openscenegraph fork.

If you have the motivation to report gcc 9 errors upstream I'm sure it would be appreciated. I don't think you need to understand every error you report on github projects 🤷‍♂️

But yeah, I think this change looks reasonable until those gcc 9 errors are fixed 👍

lheckemann
lheckemann reviewed Feb 1, 2020
View reviewed changes
pkgs/games/openmw/tes3mp.nix
@@ -71,7 +71,7 @@ in openmw.overrideAttrs (oldAttrs: rec {
description = "Multiplayer for TES3:Morrowind based on OpenMW";
homepage = https://tes3mp.com/;
license = licenses.gpl3;
platforms = platforms.linux;
platforms = [ "x86_64-linux" "i686-linux" ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this? Is it broken on aarch64-linux?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lheckemann Yes it is. This software uses sys/io.h

@ghost ghost requested a review from lheckemann February 1, 2020 12:02
@FRidh FRidh merged commit 2414e8d into NixOS:master Feb 9, 2020
@ghost ghost deleted the openmw-tes3mp branch February 9, 2020 16:28
@ghost ghost self-assigned this May 18, 2020
@ghost ghost removed their assignment May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @lheckemann @FRidh