Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockatrice: 2017-08-31 -> 2019-08-31 #78240

Merged
merged 3 commits into from Feb 1, 2020
Merged

cockatrice: 2017-08-31 -> 2019-08-31 #78240

merged 3 commits into from Feb 1, 2020

Conversation

evanjs
Copy link
Member

@evanjs evanjs commented Jan 22, 2020

Motivation for this change

Somebody expressed some interest for this on IRC but couldn't get the package working.
Ended up basically updating the whole thing so why not make a PR.

Figured I'd use the latest stable version, as the newest beta is only a month ahead of it.

App runs and initializes card database and etc fine, and I can browse through the cards after that.

Things done
  • formatting
  • add wrapQtAppsHook
  • use fetchFromGitHub instead of fetchurl
  • don't construct name manually
  • add homepage to meta
  • remove repositories.get from meta
  • use mkDerivation instead of stdenv.mkDerivation (per the Qt section of the manual)
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@spencerjanssen
Copy link
Contributor

Thank you for the patch. The changes look good to me except I get a 404 trying https://github.com/Cockatrice/Cockatrice/archive/2019-08-31.tar.gz, looks like the rev isn't correct?

I no longer use this package, if you or anyone else would like to take over maintainership please feel free.

@evanjs
cockatrice: 2017-08-31 -> 2019-08-31
c491c00 
- formatting
- add wrapQtAppsHook
- use fetchFromGitHub instead of fetchurl
- don't construct name manually
- add homepage to meta
- remove repositories.get from meta
- use mkDerivation instead of stdenv.mkDerivation
- add qtwebsockets dependency
@evanjs
Copy link
Member Author

evanjs commented Jan 22, 2020

Thanks for checking that.
Must have been after I made the change from fetchurl to fetchGitHub.
The only thing that bothers me at this point is the version name, but meh.

Anybody interested in maintaining this for now?
Totally unfamiliar with any policy related to lack of maintainers and keeping things on nixpkgs.

@ofborg ofborg bot requested a review from spencerjanssen January 22, 2020 06:49
@alyssais alyssais merged commit 4b7e4e8 into NixOS:master Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerjanssen spencerjanssen spencerjanssen approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evanjs @spencerjanssen @alyssais