Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webkitgtk: 2.26.2 -> 2.26.3 #78303

Merged
merged 1 commit into from Jan 24, 2020
Merged

webkitgtk: 2.26.2 -> 2.26.3 #78303

merged 1 commit into from Jan 24, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Jan 22, 2020 •
edited

Motivation for this change

https://webkitgtk.org/2020/01/22/webkitgtk2.26.3-released.html:

Fix issues while trying to play a video on NextCloud.
Make sure the GL video sink uses a valid WebKit shared GL context.
Fix vertical alignment of text containing arabic diacritics.
Fix build with icu 65.1.
Fix page loading errors with websites using HSTS.
Fix web process crash when displaying a KaTeX formula.
Fix several crashes and rendering issues.

The changelog doesn't mention any security fixes, but I'm guessing it's fine to target master as usual (hydra doesn't have much to do at moment anyways: https://hydra.nixos.org/queue_summary).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning
Copy link
Contributor Author

hedning commented Jan 22, 2020

Built epiphany. I'm seeing some webprocess crashes, though the problem can be reproduced in 2.26.2 too, so it doesn't look like a regression :/

@worldofpeace
Copy link
Contributor

Built epiphany. I'm seeing some webprocess crashes, though the problem can be reproduced in 2.26.2 too, so it doesn't look like a regression :/

Same, the webprocess crashes a lot. And I have a feeling it might be just in NixOS.

@worldofpeace
Copy link
Contributor

@GrahamcOfBorg build webkitgtk

@dtzWill
Copy link
Member

dtzWill commented Jan 24, 2020

Security! It was posted a day after the release, but they're all fixed by this upgrade!

https://webkitgtk.org/security/WSA-2020-0001.html

@hedning hedning merged commit 554d3a2 into NixOS:master Jan 24, 2020
@hedning hedning deleted the webkitgtk-2.26.3 branch March 1, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @worldofpeace @dtzWill