Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python27Packages.azure-mgmt-storage: 7.0.0 -> 7.1.0 #78301

Merged

Conversation

r-ryantm
Copy link
Contributor

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/python2.7-azure-mgmt-storage/versions.

meta.description for python27Packages.azure-mgmt-storage is: '"This is the Microsoft Azure Storage Management Client Library"'.

meta.homepage for python27Packages.azure-mgmt-storage is: '"https://github.com/Azure/azure-sdk-for-python"

Checks done (click to expand)
  • built on NixOS

  • Warning: a test defined in passthru.tests did not pass

  • 0 of 0 passed binary check by having a zero exit code.

  • 0 of 0 passed binary check by having the new version present in output.

  • found 7.1.0 with grep in /nix/store/rnl4zdbq15yaw6slvvqafxvxlb2d80j7-python2.7-azure-mgmt-storage-7.1.0

Rebuild report (if merged into master) (click to expand)

16 total rebuild path(s)

4 package rebuild(s)

4 x86_64-linux rebuild(s)
4 i686-linux rebuild(s)
4 x86_64-darwin rebuild(s)
4 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
azure-cli
python27Packages.azure-mgmt-storage
python37Packages.azure-mgmt-storage
python38Packages.azure-mgmt-storage

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/rnl4zdbq15yaw6slvvqafxvxlb2d80j7-python2.7-azure-mgmt-storage-7.1.0 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A python27Packages.azure-mgmt-storage https://github.com/r-ryantm/nixpkgs/archive/7d582a67a0d79828b7bf316345ca8375469135cc.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/rnl4zdbq15yaw6slvvqafxvxlb2d80j7-python2.7-azure-mgmt-storage-7.1.0
ls -la /nix/store/rnl4zdbq15yaw6slvvqafxvxlb2d80j7-python2.7-azure-mgmt-storage-7.1.0/bin

cc @olcai @mwilsoninsight for testing.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[4 built (2 failed), 118 copied (18.5 MiB), 1.7 MiB DL]
error: build of '/nix/store/yxl87q7f98q05v5gnzfsmgaqb1hhbjb3-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/78301
2 package failed to build:
fluidasserts python38Packages.azure-mgmt-storage

3 package built:
azure-cli python27Packages.azure-mgmt-storage python37Packages.azure-mgmt-storage

@jonringer
Copy link
Contributor

cc @kamadorueda this what i meant by being fragile by directly relying on azure packages :)

  Requirement already satisfied: oyaml==0.9 in /nix/store/dpqnnjfhamb7gmfp011c0kajl3zi9f25-python3.7-oyaml-0.9/lib/python3.7/site-packages (from fluidasserts==20.1.28253) (0.9)
  ERROR: Could not find a version that satisfies the requirement azure-mgmt-storage==7.0.0 (from fluidasserts==20.1.28253) (from versions: none)
  ERROR: No matching distribution found for azure-mgmt-storage==7.0.0 (from fluidasserts==20.1.28253)

@jonringer
Copy link
Contributor

at the very least, if a package does semver, you should package~=X.Y so that you can get a compatible range. For azure-mgmt-storage, that would be azure-mgmt-storage~=7.0 which would translate to -> azure-mgmt-storage>=7.0,<8

@kamadorueda
Copy link
Member

@jonringer before playing around semver, do you think we could go with an overlay or something more on the nix side ?

@jonringer
Copy link
Contributor

if you want to keep it in python-modules, then it has to be compatible with the rest of the package set. You can only really reach for an overlay if you're going to package it as an application outside of python-modules

@kamadorueda
Copy link
Member

@jonringer I'll give it a look, we always pin the versions in such a strict way to avoid things breaking in production due to a package that updated overnight, but yes, I assume we can trust the semver in a software like azure

@jonringer
Copy link
Contributor

@kamadorueda you can trust in the azure-sdk packages, but I wouldn't trust the entire azure ecosystem. Namely azure-cli and azureml* do not follow semver. but most azure-mgmt* and azure-*(azure-sdk) package do.

@jonringer
Copy link
Contributor

be careful with entries like 'azure-mgmt-security==0.*', according to semver, versions <1.0 are "unstable" and can generally do breaking changes between "minor" bumps. E.g. '0.3.0' -> '0.4.0' can break your program.

For those, I would do 'azure-mgmt-security==0.3.*'.

The version bounds for the "stable" releases look fine though.

@jonringer jonringer merged commit 2758e39 into NixOS:master Feb 22, 2020
@r-ryantm r-ryantm deleted the auto-update/python2.7-azure-mgmt-storage branch February 23, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants